Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic settings / resource loading #609

Open
wants to merge 9 commits into
base: v2
Choose a base branch
from

Conversation

jclapis
Copy link
Member

@jclapis jclapis commented Jul 23, 2024

This allows the Smart Node to load its network settings and resources from disk, rather than hardcoding them directly into the app. Patches and I have been talking about this for a while and better late than never!

Benefits are:

  • Ability to add new network configurations for new networks like Kurtosis
  • Ability to modify parameters (like URLs or addresses) for existing networks (e.g, add new previousRocketRewardsPoolAddresses directly in the settings file instead of having to build a new SN release with an updated address list).

I did my best to port the structure over from HD, but I'd test this all-the-same just to make sure I didn't miss anything. I haven't actually run this build of the SN in a vacuum to make sure all of the template parameters have been updated so pay particular attention to that. Otherwise, enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant