Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 auto init vp #633

Merged
merged 5 commits into from
Oct 11, 2024
Merged

V2 auto init vp #633

merged 5 commits into from
Oct 11, 2024

Conversation

thomaspanf
Copy link
Member

Implements #626 in V2

Copy link

Coverage Report

@0xfornax
Copy link
Member

0xfornax commented Sep 3, 2024

we can bump the rocketpool-go version now. Note the tx-refactor branch is being used for V2.

Copy link

github-actions bot commented Sep 3, 2024

Coverage Report

Copy link

Coverage Report

Copy link

Coverage Report

Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/rewards 1.21% (ø)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node 0.20% (-0.01%) 👎
github.com/rocket-pool/smartnode/v2/shared/config 5.95% (ø)
github.com/rocket-pool/smartnode/v2/shared/config/ids 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/rewards/utils.go 2.92% (ø) 1781 52 1729
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node/auto-init-voting-power.go 0.00% (ø) 356 (+356) 0 356 (+356)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node/node.go 1.16% (-0.06%) 1381 (+64) 16 1365 (+64) 👎
github.com/rocket-pool/smartnode/v2/shared/config/ids/ids.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/v2/shared/config/smartnode-config.go 3.59% (ø) 1253 45 1208

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit 75e68ea into v2 Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants