-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inner activity #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gijuno
added
Priority: Important
Scope: Presentation
Relating to user interfaces
Type: New feature
Suggesting or making new feature
labels
Aug 30, 2021
nutyworks
requested changes
Aug 30, 2021
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt
Outdated
Show resolved
Hide resolved
UI에서 줄바꿈, 정렬이 제대로 되어 있지 않고 버튼의 그림자가 잘려 있습니다. 설정 탭의 경우에는 #31 과 관련된 이슈입니다. |
nutyworks
reviewed
Aug 31, 2021
nutyworks
requested changes
Aug 31, 2021
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt
Outdated
Show resolved
Hide resolved
nutyworks
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빌드되면 머지 해주세요~
Gijuno
added
the
Resolution: Implemented
This issue is fixed or this pull request is successfully merged
label
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Important
Resolution: Implemented
This issue is fixed or this pull request is successfully merged
Scope: Presentation
Relating to user interfaces
Type: New feature
Suggesting or making new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.