Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement inner activity #52

Merged
merged 19 commits into from
Sep 3, 2021
Merged

Implement inner activity #52

merged 19 commits into from
Sep 3, 2021

Conversation

Gijuno
Copy link
Member

@Gijuno Gijuno commented Aug 30, 2021

No description provided.

@Gijuno Gijuno self-assigned this Aug 30, 2021
@Gijuno Gijuno added Priority: Important Scope: Presentation Relating to user interfaces Type: New feature Suggesting or making new feature labels Aug 30, 2021
@Gijuno Gijuno requested a review from nutyworks August 30, 2021 14:30
nutyworks
nutyworks requested changes Aug 30, 2021
View reviewed changes
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivitySelector.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/us/gijuno/gyeonhae/presentation/InnerActivity.kt Outdated Show resolved Hide resolved
@nutyworks
Copy link
Contributor

nutyworks commented Aug 30, 2021 •
edited
Loading

UI에서 줄바꿈, 정렬이 제대로 되어 있지 않고 버튼의 그림자가 잘려 있습니다. 설정 탭의 경우에는 #31 과 관련된 이슈입니다.

@Gijuno
Copy link
Member Author

Gijuno commented Aug 31, 2021

UI에서 줄바꿈, 정렬이 제대로 되어 있지 않고 버튼의 그림자가 잘려 있습니다. 설정 탭의 경우에는 #31 과 관련된 이슈입니다.

UI의 경우 추후 디자이너와 상의 후 작업할 예정이며, 설정 탭의 경우 #31 를 확인하지 못했습니다.. #31 에 관련해서는 기술 구현에 중점을 두도록 하겠습니다

@Gijuno Gijuno requested a review from nutyworks August 31, 2021 01:37
nutyworks
nutyworks approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@nutyworks nutyworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌드되면 머지 해주세요~

@Gijuno Gijuno merged commit 999a3d0 into master Sep 3, 2021
@Gijuno Gijuno deleted the implement-inner-activity branch September 3, 2021 05:44
@Gijuno Gijuno added the Resolution: Implemented This issue is fixed or this pull request is successfully merged label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutyworks nutyworks nutyworks approved these changes

Assignees

@Gijuno Gijuno

Labels
Priority: Important Resolution: Implemented This issue is fixed or this pull request is successfully merged Scope: Presentation Relating to user interfaces Type: New feature Suggesting or making new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gijuno @nutyworks