Prevent crash when ProgramBuilder.run called with no options (#1316)

rokucommunity · Oct 2, 2024 · 16b1f30 · 16b1f30
1 parent 3a2dc72
commit 16b1f30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ProgramBuilder.spec.ts b/src/ProgramBuilder.spec.ts
@@ -131,6 +131,11 @@ describe('ProgramBuilder', () => {
     });
 
     describe('run', () => {
+        it('does not crash when options is undefined', async () => {
+            sinon.stub(builder as any, 'runOnce').callsFake(() => { });
+            await builder.run(undefined as any);
+        });
+
         it('uses default options when the config file fails to parse', async () => {
             //supress the console log statements for the bsconfig parse errors
             sinon.stub(console, 'log').returns(undefined);

diff --git a/src/ProgramBuilder.ts b/src/ProgramBuilder.ts
@@ -95,7 +95,9 @@ export class ProgramBuilder {
     }
 
     public async run(options: BsConfig) {
-        this.logger.logLevel = options.logLevel;
+        if (options?.logLevel) {
+            this.logger.logLevel = options.logLevel;
+        }
 
         if (this.isRunning) {
             throw new Error('Server is already running');