fix: conform bsconfig.schema.json to strict types

[bartvandenende-wm]

Summary

bsconfig.schema.json is not (strict) type valid against jsonschema draft-07 target

fixes #1204

Details

• remove the "deprecationMessage" attribute from "ignoreErrorCodes"
• add "type": "array" to the "files".

Validation steps

1. Install npm install -g ajv-cli
2. compile schema with ajv compile -s bsconfig.schema.json --allow-union-types=true

schema bsconfig.schema.json is valid

[TwitchBronBron]

This is great! Would you be willing to add a unit test that runs the validation steps? That way we can ensure it remains in compliance with the json schema in the future.

[bartvandenende-wm]

This is great! Would you be willing to add a unit test that runs the validation steps? That way we can ensure it remains in compliance with the json schema in the future.

I could, but that likely would require us to move the bsconfig.schema.json into the TS src folder for the json to be importable for the unit test, which would be a breaking change.

[TwitchBronBron]

So vscode supports the "deprecationMessage" option, and it even shows up as deprecated in the edtior. I'm not sure we should remove that property as it provides useful error messaging in the editor. I'm sure JSON schema allows for having other properties? Or perhaps ajv-cli would have an option for ignoring that error?

[TwitchBronBron]

I added a unit test that validates the schema using ajv. The test also registers deprecationMessage as a keyword so ajv won't fail validation.

Thoughts?