Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating leading trivia #1225

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Allow updating leading trivia #1225

merged 4 commits into from
Jun 14, 2024

Conversation

markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented Jun 10, 2024 •
edited
Loading

  • All AstNodes will return an editable array of tokens when calling .getLeadingTrivia()
  • No longer concatenates leading trivia of annotations above a statement
  • Refined utils functions that get node documentation to ensure all comments are included, and these concatenate leading trivia of associated annotations

Addresses #1206

@markwpearce markwpearce added this to the v1.0.0 milestone Jun 10, 2024
@markwpearce markwpearce merged commit 136a5f6 into release-1.0.0 Jun 14, 2024
6 checks passed
@markwpearce markwpearce deleted the allow_updating_leading_trivia branch June 14, 2024 12:13
@TwitchBronBron TwitchBronBron mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@markwpearce