Convert .range to .location #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
added
the
create-package
|
Hey there! I just built a new temporary npm package based on e1a9c52. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.32-location-tracking-with-uri.20240613195621.tgz |
|
Hey there! I just built a new temporary npm package based on ee1f220. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.32-location-tracking-with-uri.20240614135552.tgz |
|
Hey there! I just built a new temporary npm package based on 91ff76e. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.32-location-tracking-with-uri.20240614171847.tgz |
markwpearce
approved these changes
Jun 14, 2024
|
I finished testing on a few projects, everything seems to be working properly. I'm going to merge this, and hopefully the next round of alpha testing will flush out any unexpected issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all
.rangeproperties to.location. This allows all tokens to know what file they came from. This is a fairly significant breaking change.TODO
.rangeto.location