Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made AstNode.getLeadingTrivia() a getter #1233

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Made AstNode.getLeadingTrivia() a getter #1233

merged 1 commit into from
Jun 14, 2024

Conversation

markwpearce
Copy link
Collaborator

  • Changed AstNode.getLeadingTrivia() to AstNode.leadingTrivia
  • Changed getEndTrivia() as well
  • Added Tests to verify comments (and changed comments) appear in transpiled output

@markwpearce markwpearce added this to the v1.0.0 milestone Jun 14, 2024
@markwpearce
Copy link
Collaborator Author

Addresses #1232

@markwpearce markwpearce merged commit dc36189 into release-1.0.0 Jun 14, 2024
4 checks passed
@markwpearce markwpearce deleted the make_ast_node_leading_trivia_a_getter branch June 14, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markwpearce @TwitchBronBron