Better symbol table type retrieval - uses parent and sibling caches #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwpearce
changed the base branch from
master
to
release-0.66.0-performance-fixes
TwitchBronBron
approved these changes
Jul 12, 2023
TwitchBronBron
added a commit
that referenced
this pull request
Jul 14, 2023
* Performance fixes * Lift `isUsedAsType` to cached expressionInfo obj * Slightly more aggressive symbol type caching * Cache speed boost * Potentially solved Scope Linking slow down (#840) * Potentially solved Scope Linking slow down * Favor focused parent lookup instead of parse-time link --------- Co-authored-by: Bronley Plumb <[email protected]> * Make CacheVerifier more stable * fix cross-platform benchmark bug * Disable execSync logging * Add specific configuration options for benchmarks at the command line (#841) Co-authored-by: Bronley Plumb <[email protected]> * Added package.json back * Small optimization during symbol table linking * Better symbol table type retrieval - uses parent and sibling caches (#842) * Better use of cache for getting symbol types * Adds space after function * Prevent leaking sibling tables * Add more benchmark padding (just cuz) * Revert `getSymbolTypeRecursive` * Better return type for `getScopeByName` * Optimize buildNamespaceLookup and some string stuff --------- Co-authored-by: Mark Pearce <[email protected]> Co-authored-by: Mark Pearce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of parent and sibling type caches on
SymbolTable.getSymbolTypemethod calls.Doesn't seem to make much difference on validate, though.