Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a modal message when the we fail to upload a package to the device #178

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Display a modal message when the we fail to upload a package to the device #178

merged 3 commits into from
Jan 2, 2024

Conversation

Christian-Holbrook
Copy link
Collaborator

@Christian-Holbrook Christian-Holbrook commented Dec 13, 2023 •
edited by TwitchBronBron
Loading

Here's a screenshot of the new modal:

image

TwitchBronBron
TwitchBronBron approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@TwitchBronBron TwitchBronBron merged commit 578949a into master Jan 2, 2024
5 checks passed
@TwitchBronBron TwitchBronBron deleted the display-modal-on-wrong-password branch January 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian-Holbrook @TwitchBronBron