Use the telnet output to know when the debug protocol port is open #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
requested changes
Dec 22, 2023
| this.socketDebugger.on('control-connected', () => { | ||
| this.connectionDeferred.resolve(); | ||
|
|
||
| this.logger.log(`Closing telnet connection used for compile errors`); |
There was a problem hiding this comment.
Let's not close this. The compileClient (telnet connection) should stay alive for the lifetime of the debug session (i.e. until someone clicks "stop")
There was a problem hiding this comment.
This was a small step to start using the telnet logs to trigger the control port connection.
I'm starting the work to keep the debug session open once the control port closes.
Co-authored-by: Bronley Plumb <[email protected]>
…Promise to isConnected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.