Support relaunch debug protocol #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bronley Plumb <[email protected]>
…Promise to isConnected
…adapter and when application is ready to launch
TwitchBronBron
requested changes
Jan 9, 2024
Co-authored-by: Bronley Plumb <[email protected]>
Co-authored-by: Bronley Plumb <[email protected]>
… it needs to be destroyed
TwitchBronBron
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the debug session for debug protocol. This is accomplished by parsing the telnet logs for the line "Waiting for debugging connection" and then creating the control port. When the application is closed, we continue to parse the telnet logs for that line. When that line is detected the control port will be created again.
A new signal
app-readyis emitted to letBrightScriptDebugSessionknow the debug adapters are ready. Both adapters have to emit this signal.When the app is closed via a home key press, reset the breakpoint managers state for the debug protocol.