Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugProtocol fixes #186

Merged
merged 4 commits into from
Feb 26, 2024
Merged

DebugProtocol fixes #186

merged 4 commits into from
Feb 26, 2024

Conversation

Christian-Holbrook
Copy link
Collaborator

Reorder when the DebugProtocolClient connects.
Reorder when 'App-Ready' event is emitted.
Add retry logic and force pause when ThreadsRequest fails with error code 4

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great finds! Just a few small suggestions.

src/adapters/DebugProtocolAdapter.ts Show resolved Hide resolved
src/adapters/DebugProtocolAdapter.ts Outdated Show resolved Hide resolved
@TwitchBronBron TwitchBronBron merged commit 6dafbbc into master Feb 26, 2024
6 checks passed
@TwitchBronBron TwitchBronBron deleted the stability-updates branch February 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants