Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial github CI #1006

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Initial github CI #1006

merged 3 commits into from
Nov 6, 2020

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Nov 6, 2020 •
edited
Loading

Description of the change

Due to ongoing perf and stability issues with Travis, this PR migrates CI to use Github Actions.

In order to unblock #1004 as soon as possible, this PR only establishes parity with the current Travis matrix, covering all Ruby versions and Rails version currently covered there.

Not addressed at this time, but should be addressed next:

  • Enable rubocop and code coverage requirements. These stopped being covered in Travis when Codacy (strangely) stopped working across all SDKs a couple months ago. In the Github Actions environment, these can be enabled without relying on Codacy.
  • Add Latest Ruby and Rails versions to the matrix.
  • Github Actions are hopefully flexible enough to add Rack and Sinatra tests that don't also load Rails or ActiveSupport.
  • Jruby builds were disabled sometime back, also due to Travis problems. This can likely be re-enabled now. (Related: Re-enable JRuby builds #884)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

ch75427

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@waltjones waltjones force-pushed the wj-github-ci branch 6 times, most recently from 7f34f99 to 4472657 Compare November 6, 2020 14:12
@waltjones waltjones force-pushed the wj-github-ci branch 16 times, most recently from 2d3451e to b6580f9 Compare November 6, 2020 17:57
@waltjones waltjones changed the title WIP: Initial github ci Initial github CI Nov 6, 2020
@waltjones waltjones force-pushed the wj-github-ci branch 6 times, most recently from a9c6004 to 397cec8 Compare November 6, 2020 18:43
@waltjones waltjones force-pushed the wj-github-ci branch 13 times, most recently from f01be1a to 048be64 Compare November 6, 2020 21:06
ajtran
ajtran approved these changes Nov 6, 2020
View reviewed changes
Copy link

@ajtran ajtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good to me!

@waltjones waltjones merged commit ac61df1 into master Nov 6, 2020
@waltjones waltjones deleted the wj-github-ci branch June 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtran ajtran ajtran approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waltjones @ajtran