Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable scoped block for DelayedJob plugin #1087

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

iangreenleaf
Copy link
Contributor

Description of the change

Adds a new configuration option to run DelayedJob invocations in a scoped block. When enabled, this adds job data to any Rollbar reporting that happens within the job, and prevents changes to the scope (like calling scope! within a job) from polluting the global scope for other jobs.

I noticed that the Sidekiq plugin had an option for this (#1038) so I followed that format.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

iangreenleaf and others added 2 commits February 28, 2022 16:50
When enabled, this adds job data to any Rollbar reporting that happens
within the job, and prevents changes to the scope from polluting the
global scope for other jobs.
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iangreenleaf Thank you for the PR.

@waltjones waltjones merged commit 4556623 into rollbar:master Dec 19, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants