Possibility to use service as person_fn rather than a static function #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zinkovskiy, we are looking for a maintainer or owner of the repo. Would you like to participate? |
Hi @zdavis-rollbar yes, I'm ready to maintain. contact me anytime when you have time, we are interested in keeping the project up to date |
|
@zinkovskiy Thank you for the PR. Please add tests for the new functionality, and run tests locally to ensure CI will pass. |
Hi @waltjones, yes, I missed it. Now it's added |
danielmorell
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR allow to use service as
person_fnI created PersonProvider service that is used by default
To use custom person provider you need to define your own service with alias
rollbar.person-providerin services.yml of your application, for example:No need to define
person_fnoption (thx to DI), the service will be used automatically, but ifperson_fnis defined, then it will be usedLogic of obtaining user info is not changed.
I've also discovered, that
security.token_storageandserializerare private and cannot be obtained from container, so I passed it toRollbar\Symfony\RollbarBundle\Factories\RollbarHandlerFactoryconstructorType of change
Related issues
Checklists
Development
Code review
I tested these changes on symfony 5.4 and symfony 6.4, it works well
@danielmorell could you please take a look on it?