Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: integrate rolldown dev #66

Draft
wants to merge 66 commits into
base: rolldown-v6
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
4b310b7
feat: use rolldown in the dep optimizer
sapphi-red Sep 11, 2024
82fea72
feat: use rolldown for build
sapphi-red Sep 12, 2024
4803f6c
chore: skip plugin-legacy build
sapphi-red Sep 12, 2024
cae9de7
chore: skip typecheck for now
sapphi-red Sep 12, 2024
15bdbca
chore: 🤖 add justfile for faster dev
IWANABETHATGUY Aug 15, 2024
6a5c12f
feat: add experimental.enableNativePlugin (#41)
IWANABETHATGUY Sep 10, 2024
d2abb2d
feat: clone class plugins correctly
IWANABETHATGUY Sep 13, 2024
83e64f0
feat: native build plugins (#45) (#46)
IWANABETHATGUY Sep 12, 2024
7607377
perf: reduce pre alias plugin in build mode
IWANABETHATGUY Sep 12, 2024
2917b77
feat: 🎸 add an new option to disable build report
IWANABETHATGUY Sep 13, 2024
88ee06e
feat: support native define
sapphi-red Sep 18, 2024
155fe98
feat: use filter for plugins (#49) (#50) (#51) (#52) (#53)
sapphi-red Sep 18, 2024
34772a5
perf: ⚡️ use default resolver (#56)
IWANABETHATGUY Sep 14, 2024
8c2c27f
fix: 🐛 lint (#58)
IWANABETHATGUY Sep 20, 2024
9ad08d1
chore: bump rolldown
sapphi-red Sep 24, 2024
852c221
chore: skip data uri by load fallback plugin for native data uri hand…
sapphi-red Sep 24, 2024
6a4d274
feat: handle non-relative paths by Vite's resolver for enableNativePl…
sapphi-red Sep 19, 2024
866e97d
chore: remove browser field edge case test
sapphi-red Sep 25, 2024
cf3aa12
chore: use advancedChunks instead of manualChunks
sapphi-red Oct 1, 2024
72b6177
feat: convert `optimizeDeps.esbuildOptions` to `optimizeDeps.rollupOp…
sapphi-red Oct 4, 2024
a5ce12c
fix: optimizeDeps test pass on windows
sapphi-red Oct 9, 2024
c1b13da
chore: make some tests passing
sapphi-red Oct 9, 2024
94cf842
chore: make glob-import test pass with workarounds
sapphi-red Oct 9, 2024
a6873b6
chore: run worker-es tests
sapphi-red Oct 9, 2024
9872f25
fix: use preliminaryFileName for chunkMetadata key
sapphi-red Oct 10, 2024
747f26b
feat: oxc tranformer (#60)
underfin Oct 11, 2024
1a228be
feat: use `onlyRemoveTypeImports`
sapphi-red Oct 11, 2024
cce68ef
chore: enable continuous release under rolldown-vite (#61)
yyx990803 Oct 12, 2024
6e3fd69
feat: environment aware native plugins
sapphi-red Oct 15, 2024
bc223cd
feat: export transformWithOxc (#62)
underfin Oct 17, 2024
c967ea7
feat: add oxc jsxInclude and jsxExclude (#63)
underfin Oct 18, 2024
2e134f1
chore: update some tests that relies on rollup's behavior
sapphi-red Oct 24, 2024
e483ce3
chore: skip environment-react-ssr for now
sapphi-red Oct 24, 2024
45288b4
chore: bump rolldown
sapphi-red Oct 24, 2024
e9ae3e2
chore: skip minifySyntax test as it relies on specific esbuild option
sapphi-red Oct 24, 2024
71c744f
chore: fix type errors
sapphi-red Oct 24, 2024
0043810
chore: skip sideeffects set for HTML scripts for now
sapphi-red Nov 6, 2024
aec2b6e
chore: partial revert "refactor: use `originalFileNames`/`names` (#18…
sapphi-red Nov 6, 2024
396d3af
chore: tweak tests
sapphi-red Nov 6, 2024
94cf27f
chore: bump rolldown
sapphi-red Nov 6, 2024
1f825b9
chore: enable backend-integration test
sapphi-red Nov 6, 2024
448f8e0
chore: skip error message test
sapphi-red Nov 13, 2024
03ef4bc
feat: enable lib mode tests (#64)
sapphi-red Nov 13, 2024
0c0a17b
chore: fix LICENSE
sapphi-red Nov 14, 2024
a5ed542
chore: uncomment things implemented on rolldown now
sapphi-red Nov 18, 2024
1c77f54
chore: enable html sideeffects test
sapphi-red Nov 18, 2024
8f8c69d
chore: reduce diff
sapphi-red Nov 18, 2024
59c8b5b
feat: use native Vite resolver (#65)
sapphi-red Nov 19, 2024
04a742c
chore: add workaround and make environment-react-ssr playground pass
sapphi-red Nov 21, 2024
067347d
chore: add comment
sapphi-red Nov 21, 2024
bff6200
chore: fix oxc option convertion and reduce warnings
sapphi-red Nov 22, 2024
64ba053
chore: bump rolldown
sapphi-red Nov 25, 2024
cc6c2e0
chore: update snapshot
sapphi-red Nov 25, 2024
6f6bb59
chore: fix for new vite resolve plugin
sapphi-red Nov 25, 2024
fb67381
feat: use native plugin for create id resolver (#68)
sapphi-red Nov 25, 2024
b392159
chore: bump rolldown
sapphi-red Nov 28, 2024
f4bc379
chore: fix for the latest rolldown
sapphi-red Nov 28, 2024
8f637cf
chore: enable modulepreload unit test
sapphi-red Nov 28, 2024
7c8a9ee
chore: bump rolldown
sapphi-red Nov 29, 2024
68e6581
chore: set platform option and remove workaround in environment-react…
sapphi-red Nov 29, 2024
4753f60
chore: update some tests that relies on rollup's behavior
sapphi-red Nov 29, 2024
48f59ce
feat: use rolldown for config loader (#69)
sapphi-red Nov 29, 2024
5a51f96
feat: use rolldown effectively for the optimizer (#70)
sapphi-red Nov 29, 2024
7440a62
feat: integrate rolldown hmr-poc
hi-ogawa Nov 14, 2024
2a0948c
wip: ssr module runner
hi-ogawa Nov 15, 2024
304d625
chore: use latest build
hi-ogawa Nov 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: bump rolldown
  • Loading branch information
sapphi-red committed Nov 29, 2024
commit 9ad08d121f5236cf48066af7d0e3377dac3df768
2 changes: 1 addition & 1 deletion packages/vite/package.json
Original file line number Diff line number Diff line change
@@ -87,7 +87,7 @@
"dependencies": {
"esbuild": "^0.24.0",
"postcss": "^8.4.49",
"rolldown": "https://pkg.pr.new/rolldown@dab103f",
"rolldown": "https://pkg.pr.new/rolldown@e65437c",
"rollup": "^4.23.0"
},
"optionalDependencies": {
5 changes: 5 additions & 0 deletions packages/vite/src/node/build.ts
Original file line number Diff line number Diff line change
@@ -635,6 +635,11 @@ async function buildEnvironment(
onwarn(warning, warn) {
onRollupWarning(warning, warn, environment)
},
// TODO: remove this and enable rolldown's CSS support later
moduleTypes: {
...options.rollupOptions.moduleTypes,
'.css': 'js',
},
}

/**
10 changes: 10 additions & 0 deletions packages/vite/src/node/optimizer/index.ts
Original file line number Diff line number Diff line change
@@ -789,6 +789,11 @@ async function prepareRolldownOptimizerRun(
conditionNames: ['browser'],
},
...rollupOptions,
// TODO: remove this and enable rolldown's CSS support later
moduleTypes: {
'.css': 'js',
...rollupOptions.moduleTypes,
},
})
if (canceled) {
await bundle.close()
@@ -1068,6 +1073,11 @@ export async function extractExportsData(
...remainingRollupOptions,
plugins,
input: [filePath],
// TODO: remove this and enable rolldown's CSS support later
moduleTypes: {
'.css': 'js',
...remainingRollupOptions.moduleTypes,
},
})
const result = await build.generate({
...rollupOptions.output,
5 changes: 5 additions & 0 deletions packages/vite/src/node/plugins/worker.ts
Original file line number Diff line number Diff line change
@@ -88,6 +88,11 @@ async function bundleWorkerEntry(
onwarn(warning, warn) {
onRollupWarning(warning, warn, workerEnvironment)
},
// TODO: remove this and enable rolldown's CSS support later
moduleTypes: {
'.css': 'js',
...rollupOptions.moduleTypes,
},
// preserveEntrySignatures: false,
})
let chunk: OutputChunk
6 changes: 4 additions & 2 deletions packages/vite/src/node/server/pluginContainer.ts
Original file line number Diff line number Diff line change
@@ -73,6 +73,7 @@ import {
normalizePath,
numberToPos,
prettifyUrl,
rolldownVersion,
rollupVersion,
timeFrom,
} from '../utils'
@@ -178,6 +179,7 @@ class EnvironmentPluginContainer {
this.minimalContext = {
meta: {
rollupVersion,
rolldownVersion,
watchMode: true,
},
debug: noop,
@@ -543,15 +545,15 @@ class PluginContext implements Omit<RollupPluginContext, 'cache'> {
_activeId: string | null = null
_activeCode: string | null = null
_resolveSkips?: Set<Plugin>
// meta: RollupPluginContext['meta']
meta: RollupPluginContext['meta']
environment: Environment

constructor(
public _plugin: Plugin,
public _container: EnvironmentPluginContainer,
) {
this.environment = this._container.environment
// this.meta = this._container.minimalContext.meta
this.meta = this._container.minimalContext.meta
}

parse(code: string, opts: any) {
7 changes: 5 additions & 2 deletions packages/vite/src/node/utils.ts
Original file line number Diff line number Diff line change
@@ -146,8 +146,11 @@ const _require = createRequire(import.meta.url)

const _dirname = path.dirname(fileURLToPath(import.meta.url))

// NOTE: we don't use VERSION variable exported from rollup to avoid importing rollup in dev
export const rollupVersion =
// https://github.com/rolldown/rolldown/blob/7bc51f099a916dbe31bc0582995c58cf0d0f8924/packages/rolldown/src/log/logger.ts#L67
export const rollupVersion = '4.23.0'

// NOTE: we don't use VERSION variable exported from rolldown to avoid importing rolldown in dev
export const rolldownVersion =
resolvePackageData('rolldown', _dirname, true)?.data.version ?? ''

// set in bin/vite.js
106 changes: 53 additions & 53 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.