refactor: remove old mentors routes (#2458)

rolling-scopes · Apr 11, 2024 · b5f6767 · b5f6767
1 parent e4cff04
commit b5f6767
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 137 deletions.
diff --git a/server/src/routes/course/index.ts b/server/src/routes/course/index.ts
@@ -25,7 +25,6 @@ import {
   postMentor,
   restoreExpelledMentor,
 } from './mentor';
-import * as mentors from './mentors';
 import * as score from './score';
 import * as stageInterview from './stageInterview';
 import {
@@ -150,11 +149,6 @@ function addStageInterviewApi(router: Router<any, any>, logger: ILogger) {
 function addMentorApi(router: Router<any, any>, logger: ILogger) {
   const validators = [validateGithubIdAndAccess];
 
-  const mentorsLogger = logger.child({ module: 'course/mentors' });
-  router.get('/mentors', courseSupervisorGuard, mentors.getMentors(mentorsLogger));
-  router.post('/mentors', adminGuard, mentors.createMentors(mentorsLogger));
-  router.post('/mentors/students', courseSupervisorGuard, mentors.assignStudents(mentorsLogger));
-
   const mentorLogger = logger.child({ module: 'course/mentor' });
   router.post('/mentor/:githubId', guard, ...validators, postMentor(mentorLogger));
   router.post('/repositories/mentor/:githubId', courseManagerGuard, ...validators, inviteMentorToTeam(mentorLogger));

diff --git a/server/src/routes/course/mentors/assignStudents.ts b/server/src/routes/course/mentors/assignStudents.ts
diff --git a/server/src/routes/course/mentors/createMentors.ts b/server/src/routes/course/mentors/createMentors.ts
diff --git a/server/src/routes/course/mentors/getMentors.ts b/server/src/routes/course/mentors/getMentors.ts
diff --git a/server/src/routes/course/mentors/index.ts b/server/src/routes/course/mentors/index.ts
diff --git a/server/src/services/course.service.ts b/server/src/services/course.service.ts
@@ -316,22 +316,6 @@ export async function getCrossStudentsByMentor(courseId: number, githubId: strin
   return students;
 }
 
-export async function getMentors(courseId: number): Promise<MentorDetails[]> {
-  const records = await mentorQuery()
-    .innerJoin('mentor.user', 'user')
-    .addSelect(getPrimaryUserFields())
-    .innerJoin('mentor.course', 'course')
-    .leftJoin('mentor.students', 'students')
-    .addSelect(['students.id'])
-    .leftJoinAndSelect('mentor.stageInterviews', 'stageInterviews')
-    .where(`course.id = :courseId`, { courseId })
-    .orderBy('mentor.createdDate')
-    .getMany();
-
-  const mentors = records.map(convertToMentorDetails);
-  return mentors;
-}
-
 export async function getMentorsWithStudents(courseId: number): Promise<MentorDetails[]> {
   const records = await mentorQuery()
     .innerJoin('mentor.user', 'user')

diff --git a/server/src/services/mentor.service.ts b/server/src/services/mentor.service.ts