Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terms of service checkbox to students registry #2534

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EternalRival
Copy link
Contributor

@EternalRival EternalRival commented Oct 3, 2024

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

Describe the source of requirement, like related issue link.

πŸ’‘ Background and solution

Students ignore the existence of documentation and announcement channel.
Because of this, they miss important information.
I think that by additionally agreeing to monitor announcements from course supervisors and familiarize themselves with the documentation, fewer students will get into unpleasant situations in the learning process.

My solution is to add a checkbox about β€œdocs and announcements” to the registration form, similar to the existing checkbox about data processing.
The component itself for this checkbox and things for it was written similar to the DataProcessingCheckbox component.

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

⚠️ Unfortunately, I do not have the opportunity to test the changes locally, because it was not possible to run the project in my environment.
I hope to find someone who can run the project locally and check if I am missing something and if everything is ok.

@EternalRival
Copy link
Contributor Author

@valerydluski
Copy link
Contributor

In my opinion, adding such a checkbox will not affect whether students read the announcements and documentation, but will only overload the registration form.
I also think that this is not part of the registration process, as it relates more to the rules of specific courses.

@valerydluski
Copy link
Contributor

And one more argument from my side: we already have notifications that users can subscribe to, and if those don't help keep them informed of important updates, then a checkbox clearly won't be of much use either.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants