-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*)!: set min node engine version to v18 #1585
Conversation
got some CI issues there |
I have a hope that it is a pnpm bug fixed in v8.7.6, will check tonight. |
@lukastaegert i have that hope, too. I also think that in the pr #1595 it is the same problem. |
@lukastaegert the |
@shellscape i think this pr should be ready to merge. |
I'm going to be working on the CI system here this week, and one that allows a wildcard scope so that any affected package is published. We've had to include a bananas-long ass scope too many times now. Once that's done we can merge this. I'll keep you posted. |
Sounds good! Maybe Lerna is an option. I use it for many projects and it is pretty awesome 😌 |
Lerna is an absolute dumpster fire and the 2nd biggest pile of excrement for a devtool I've ever had the displeasure of using. It is only second to Nx in its awfulness. 😅 |
Working on this today. Have an elegant solution in mind. |
c544fde
to
a929458
Compare
Merged the update to the release pipeline but it needs an adjustment to account for the leading |
a69c299
to
a9b9cd3
Compare
OK we're good to go |
@tada5hi please update your branch from upstream/master |
BREAKING CHANGE: min version changed
@shellscape i rebased the branch, but there seems to be an issue with the changed pr title. |
I fixed that on master. We'll bypass that. Will pull the trigger on this tomorrow after noon ET when I can babysit releasing the freaking world 😅 |
should i rebase it again ? |
We've got this #1618 PR for commonjs open which is going to be a breaking change/major, so I'd like to hold off just a bit on this one until we can get that resolved. I'll be trying to squeeze that change in without a release so we only get one major release for commonjs. |
BREAKING CHANGE: min version changed
Rollup Plugin Name:
{name}
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1580
Description