Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitcoin dependency to 0.31.0 #941

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

tcharding
Copy link
Contributor

This is not a merge candidate.

Upgrade dependencies required to use the recently released rust-bitcoin v0.31.0-rc1 release.

Done while trying to upgrade bdk to use the bitcoin RC release.

@tcharding
Copy link
Contributor Author

Bother, I was supposed to be doing electrsd not electrs. Anyhow, I'll leave this here in case its useful for you later on @romanz.

@romanz
Copy link
Owner

romanz commented Oct 16, 2023

Thanks!

@romanz romanz force-pushed the 10-16-upgrade-bitcoin branch 2 times, most recently from 0565c53 to 01f50ac Compare October 17, 2023 15:44
@romanz
Copy link
Owner

romanz commented Oct 25, 2023

Testing 0.31.0-rc2

@tcharding
Copy link
Contributor Author

tcharding commented Oct 25, 2023

No public changes between rc1 an rc2, should be sweet. Thanks for testing man!

EDIT: lol, typing just as CI threw a red cross. oh, looks unrelated.

@romanz
Copy link
Owner

romanz commented Oct 31, 2023

Squashed and rebased after rust-bitcoin v0.31.0 release.

The following are needed for this PR:

@romanz romanz changed the title Upgrade bitcoin Upgrade bitcoin dependency to 0.31.0 Oct 31, 2023
@romanz romanz added the dependencies Pull requests that update a dependency file label Oct 31, 2023
@romanz romanz force-pushed the 10-16-upgrade-bitcoin branch 2 times, most recently from a8a3f4a to c122254 Compare November 6, 2023 19:07
@romanz
Copy link
Owner

romanz commented Nov 6, 2023

Synced with rust-bitcoin/rust-bitcoincore-rpc#313.

Upgrade dependencies required to use the recently released
`rust-bitcoin v0.31.0` release.

Co-authored-by: Roman Zeyde <[email protected]>
@romanz romanz marked this pull request as ready for review November 15, 2023 18:37
@romanz romanz merged commit b6271ba into romanz:master Nov 15, 2023
4 checks passed
@romanz
Copy link
Owner

romanz commented Nov 15, 2023

Many thanks @tcharding!

@tcharding
Copy link
Contributor Author

No worries man, wish I had updated the PR description before you merged :)

@romanz
Copy link
Owner

romanz commented Nov 16, 2023

Oops, you're right - sorry for the quick merge...

@tcharding
Copy link
Contributor Author

My fault, I saw you pushing weeks ago and didn't fix it. Not to worry. Thanks man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants