Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*Gateway): support ERC721Batch, ERC1155Batch #15

Draft
wants to merge 27 commits into
base: release/v3.2.0
Choose a base branch
from
Draft

feat(*Gateway): support ERC721Batch, ERC1155Batch #15

wants to merge 27 commits into from

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Mar 13, 2024 •
edited
Loading

Description

Features

  • Support ERC721Batch
  • Support ERC1155Batch

Impl changes

  • Split Owner and Info into two separate libs
  • Rename the exposed methods in lib to handleAssetIn/Out
  • Add different hash for Batch request, reserve the legacy hash for Single request for backward-compatible
  • Minor refactor and code convention

TODO

  • Benchmark gas in batch request and restrict the number of ids in a request.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao
fix(Token): nit prettier Token lib
5078d3e
@nxqbao
fix(Token): rename _ for internal lib
cb1706f
@nxqbao
fix(Owner): move TokenOwner to a separate lib
079fa61
@nxqbao
fix(Info): move to LibTokenInfo
c7751f5
@nxqbao
fix(Info): add two array fields for info
d4c7a9b
@nxqbao
fix(Info): validate erc1155 and erc721 batch
77396ac
@nxqbao
fix(Info): add router
8d0becb
@nxqbao
fix(Info): restrict scope of tryTransfer to private
68b9c86
@nxqbao
feat(Info): support hash batch
6efc05a
@nxqbao
fix(Info): move helpers to EoF
66b166a
@nxqbao
fix(Info): refactor handleAssetTransfer
eb9a888
@nxqbao
feat(Info): rename transferFrom to handleTransferFrom
fe51f39
@nxqbao
fix(Info): rename to ERC1155Batch
f65c25d
@nxqbao
fix(Info): return instead of nested if-else
5090262
@nxqbao
feat(Info): impl transfer1155
ec8adac
@nxqbao
feat(Info): mint and transfer 1155 in batch
87c1c15
@nxqbao
fix(Gateway): rename tranferFrom to handleAssetIn
a9649a5
@nxqbao
fix((Info): rework the transfer methods
f722a9c
@nxqbao
fix(Info): transfer in ERC721 by private method
bb4d8b9
@nxqbao
fix(Info): support ERC721Batch
69df309
@nxqbao
fix(Info): chore: update docs
3d39232
@nxqbao
fix(Info): fix validation
e9d6435
@nxqbao
BREAKING CHANGE: add Mode to Request, group Manifest in Receipt, fix …
7393761 
…Receipt hash
@nxqbao
Copy link
Contributor Author

nxqbao commented Apr 8, 2024

This PR is kept for future development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @TuDo1403