prefer closedAt over updatedAt for closed issues

ropensci-review-tools · Mar 7, 2024 · 0f91bf5 · 0f91bf5
1 parent 2913af1
commit 0f91bf5
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: dashboard
 Title: What the Package Does (One Line, Title Case)
-Version: 0.0.1.001
+Version: 0.0.1.002
 Authors@R: 
   person(given = "First",
          family = "Last",

diff --git a/R/editors.R b/R/editors.R
@@ -23,7 +23,7 @@ editor_gh_data <- function () {
     has_next_page <- TRUE
     end_cursor <- NULL
 
-    number <- state <- assignees <- updated_at <- titles <- NULL
+    number <- state <- assignees <- updated_at <- closed_at <- titles <- NULL
 
     page_count <- 0L
 
@@ -59,6 +59,13 @@ editor_gh_data <- function () {
             updated_at,
             vapply (nodes, function (i) i$updatedAt, character (1L))
         )
+        # closedAt is 'null' for open issues:
+        closed_at <- c (
+            closed_at,
+            vapply (nodes, function (i) {
+                ifelse (is.null (i$closedAt), "", i$closedAt)
+            }, character (1L))
+        )
         titles <- c (
             titles,
             vapply (nodes, function (i) i$title, character (1L))
@@ -77,8 +84,13 @@ editor_gh_data <- function () {
     state <- state [index]
     assignees <- assignees [index]
     updated_at <- updated_at [index]
+    closed_at <- closed_at [index]
     titles <- titles [index]
 
+    # Prefer closedAt over updatedAt for closed issues:
+    index <- which (nzchar (closed_at))
+    updated_at [index] <- closed_at [index]
+
     # Then find latest issue for each editor:
     ed_index <- vapply (editors$login, function (i) {
         index <- which (vapply (assignees, function (j) any (j == i), logical (1L)))

diff --git a/R/gh-queries.R b/R/gh-queries.R
@@ -143,6 +143,7 @@ gh_issue_assignees_qry <- function (org = "ropensci",
                        nodes {
                            number
                            state
+                           closedAt
                            updatedAt
                            assignees (first: 100) {
                                nodes {

diff --git a/codemeta.json b/codemeta.json
@@ -6,7 +6,7 @@
   "name": "dashboard: What the Package Does (One Line, Title Case)",
   "codeRepository": "https://github.com/ropensci-review-tools/dashboard",
   "license": "https://spdx.org/licenses/MIT",
-  "version": "0.0.1.001",
+  "version": "0.0.1.002",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",
-Original file line number
+Diff line change
@@ Expand Up / @@ -143,6 +143,7 @@ gh_issue_assignees_qry <- function (org = "ropensci", @@
                            nodes {
                                number
                                state
+                               closedAt
                                updatedAt
                                assignees (first: 100) {
                                    nodes {
@@ Expand Down @@