Try fixing issues

ropensci · Feb 28, 2024 · fe36c20 · fe36c20
1 parent 44dc4d4
commit fe36c20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/R/cff_create_person.R b/R/cff_create_person.R
@@ -230,7 +230,7 @@ hint_person <- function(person) {
   ) {
     # guess orcid
     norc <- min(unlist(regexpr("orcid.org/", comment_as_text)))
-    if (orc_text < 0) {
+    if (norc < 0) {
       parsed_comments <- list()
     } else {
       orcid <- substr(comment_as_text, norc, nchar(comment_as_text))
@@ -287,6 +287,7 @@ hint_person <- function(person) {
 
 hint_bibtex <- function(person) {
   person <- trimws(person)
+  person <- unname(person)
 
   # Remove role on [] as it comes from print.person by default
   person <- gsub("\\[[^()]*\\]", "", person)

diff --git a/R/parse_citation.R b/R/parse_citation.R
@@ -139,6 +139,9 @@ building_other_persons <- function(parsed_fields) {
   toentity_pers <- others[names(others) %in% toent_pers]
   toentity_pers <- lapply(toentity_pers, function(x) {
     bibtex <- paste(x, collapse = " and ")
+    # Unname
+    names(bibtex) <- NULL
+
 
     end <- cff_parse_person_bibtex(bibtex)