-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state message for mechanum controller #79
Merged
bmagyar
merged 4 commits into
ros-controls:master
from
StoglRobotics-forks:adding-mecanum-drive-controller-state-msg
Mar 22, 2023
Merged
Add state message for mechanum controller #79
bmagyar
merged 4 commits into
ros-controls:master
from
StoglRobotics-forks:adding-mecanum-drive-controller-state-msg
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
force-pushed
the
adding-mecanum-drive-controller-state-msg
branch
from
January 27, 2023 22:54
bc43460
to
bd364e8
Compare
destogl
commented
Jan 30, 2023
destogl
commented
Jan 30, 2023
destogl
commented
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now! Thanks!
destogl
force-pushed
the
adding-mecanum-drive-controller-state-msg
branch
from
January 31, 2023 14:21
a96046f
to
6e3b1b5
Compare
@bmagyar what do you think that we name this status message instead of state. |
destogl
commented
Mar 22, 2023
destogl
commented
Mar 22, 2023
destogl
commented
Mar 22, 2023
destogl
commented
Mar 22, 2023
bmagyar
approved these changes
Mar 22, 2023
@Mergifyio backport humble |
✅ Backports have been created
|
bmagyar
added a commit
that referenced
this pull request
Mar 22, 2023
* adding msg file, changes in cmakelists nd package.xml (cherry picked from commit df9cd98) * Apply suggestions from code review Co-authored-by: Dr. Denis <[email protected]> (cherry picked from commit 348a134) * ran pre-commit formatter (cherry picked from commit 74512e4) * Apply suggestions from code review (cherry picked from commit d5a2c0d) --------- Co-authored-by: GiridharBukka <[email protected]> Co-authored-by: Robotgir <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Bence Magyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement for ros-controls/ros2_controllers#512