Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state message for mechanum controller #79

Conversation

destogl
Copy link
Member

@destogl destogl commented Jan 27, 2023

@destogl destogl force-pushed the adding-mecanum-drive-controller-state-msg branch from bc43460 to bd364e8 Compare January 27, 2023 22:54
@destogl destogl requested a review from bmagyar January 30, 2023 13:56
Copy link
Member Author

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! Thanks!

@destogl destogl force-pushed the adding-mecanum-drive-controller-state-msg branch from a96046f to 6e3b1b5 Compare January 31, 2023 14:21
@destogl
Copy link
Member Author

destogl commented Jan 31, 2023

@bmagyar what do you think that we name this status message instead of state.

control_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
control_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
control_msgs/package.xml Outdated Show resolved Hide resolved
@bmagyar bmagyar merged commit d5a2c0d into ros-controls:master Mar 22, 2023
@bmagyar
Copy link
Member

bmagyar commented Mar 22, 2023

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Mar 22, 2023

backport humble

✅ Backports have been created

bmagyar added a commit that referenced this pull request Mar 22, 2023
* adding msg file, changes in cmakelists nd package.xml

(cherry picked from commit df9cd98)

* Apply suggestions from code review

Co-authored-by: Dr. Denis <[email protected]>
(cherry picked from commit 348a134)

* ran pre-commit formatter

(cherry picked from commit 74512e4)

* Apply suggestions from code review

(cherry picked from commit d5a2c0d)

---------

Co-authored-by: GiridharBukka <[email protected]>
Co-authored-by: Robotgir <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Bence Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants