Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improvements and Cleanups #1028

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 7, 2024

RHEL/Debian

  • Build and test only the packages from this repo, instead of all packages imported with the repos file. I used colcon list instead of hardcoding it as it is done with the lint jobs.
  • Split build and test steps, and let the test step continue-on-error: The main goal is to detect compilation problems with unsupported C++ features, which are now visible at first glance. Tests remain flaky on theses platforms, which is a different issue.
  • use reusable workflows for both platforms
  • use a semi-binary build for RHEL

Others

  • Use a single package list for lint job
  • Remove the wrong branch field below workflow_dispatch

Backport after #1016 and #1017/#1029 and #1030

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (9f7e9e9) 47.71% compared to head (b2aee2c) 71.71%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1028       +/-   ##
===========================================
+ Coverage   47.71%   71.71%   +24.00%     
===========================================
  Files          41       41               
  Lines        3871     3628      -243     
  Branches     1833     1777       -56     
===========================================
+ Hits         1847     2602      +755     
+ Misses        751      714       -37     
+ Partials     1273      312      -961     
Flag Coverage Δ
unittests 71.71% <70.37%> (+24.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 68.63% <100.00%> (+20.57%) ⬆️
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
...roadcaster/src/force_torque_sensor_broadcaster.cpp 82.53% <75.00%> (+21.93%) ⬆️
...ory_controller/src/joint_trajectory_controller.cpp 80.39% <83.33%> (+33.28%) ⬆️
tricycle_controller/src/tricycle_controller.cpp 60.94% <60.60%> (+28.29%) ⬆️

... and 31 files with indirect coverage changes

@bmagyar bmagyar merged commit 1266941 into ros-controls:master Feb 9, 2024
13 of 16 checks passed
@christophfroehlich christophfroehlich deleted the ci_cleanup branch February 11, 2024 22:37
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants