Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Code coverage + pre-commit (backport #1057) #1065

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2024

This is an automatic backport of pull request #1057 done by Mergify.
Cherry-pick of 00172ab has failed:

On branch mergify/bp/iron/pr-1057
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 00172ab.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .github/workflows/ci-format.yml
	new file:   .github/workflows/humble-coverage-build.yml
	new file:   .github/workflows/humble-pre-commit.yml
	new file:   .github/workflows/iron-coverage-build.yml
	new file:   .github/workflows/iron-pre-commit.yml
	new file:   .github/workflows/rolling-coverage-build.yml
	new file:   .github/workflows/rolling-pre-commit.yml
	new file:   .github/workflows/update-pre-commit.yml
	modified:   .pre-commit-config.yaml
	modified:   rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
	modified:   rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/update_combo.py
	modified:   rqt_joint_trajectory_controller/setup.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/ci-coverage-build-humble.yml
	deleted by them: .github/workflows/ci-coverage-build-iron.yml
	deleted by them: .github/workflows/ci-coverage-build.yml
	deleted by them: .github/workflows/ci-ros-lint.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Feb 27, 2024
Copy link
Contributor Author

mergify bot commented Feb 27, 2024

Cherry-pick of 00172ab has failed:

On branch mergify/bp/iron/pr-1057
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 00172ab.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .github/workflows/ci-format.yml
	new file:   .github/workflows/humble-coverage-build.yml
	new file:   .github/workflows/humble-pre-commit.yml
	new file:   .github/workflows/iron-coverage-build.yml
	new file:   .github/workflows/iron-pre-commit.yml
	new file:   .github/workflows/rolling-coverage-build.yml
	new file:   .github/workflows/rolling-pre-commit.yml
	new file:   .github/workflows/update-pre-commit.yml
	modified:   .pre-commit-config.yaml
	modified:   rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
	modified:   rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/update_combo.py
	modified:   rqt_joint_trajectory_controller/setup.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/ci-coverage-build-humble.yml
	deleted by them: .github/workflows/ci-coverage-build-iron.yml
	deleted by them: .github/workflows/ci-coverage-build.yml
	deleted by them: .github/workflows/ci-ros-lint.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (b6558d1) to head (cbaac99).
Report is 21 commits behind head on iron.

Additional details and impacted files
@@             Coverage Diff             @@
##             iron    #1065       +/-   ##
===========================================
- Coverage   47.70%   35.49%   -12.21%     
===========================================
  Files          40       55       +15     
  Lines        3664     6741     +3077     
  Branches     1739     4174     +2435     
===========================================
+ Hits         1748     2393      +645     
- Misses        712     1267      +555     
- Partials     1204     3081     +1877     
Flag Coverage Δ
unittests 35.49% <ø> (-12.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 95 files with indirect coverage changes

@bmagyar bmagyar merged commit 4941fee into iron Feb 29, 2024
12 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1057 branch February 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants