Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Deprecate start_with_holding #1076

Merged

Conversation

christophfroehlich
Copy link
Contributor

It was decided not to remove start_with_holding in iron/humble, see #839 and #876.
So let's deprecate it.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

Copy link
Contributor

mergify bot commented Mar 13, 2024

backport humble

✅ Backports have been created

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.59%. Comparing base (32757e1) to head (c696df0).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1076      +/-   ##
==========================================
- Coverage   71.61%   71.59%   -0.03%     
==========================================
  Files          40       40              
  Lines        3449     3450       +1     
  Branches     1695     1698       +3     
==========================================
  Hits         2470     2470              
- Misses        676      682       +6     
+ Partials      303      298       -5     
Flag Coverage Δ
unittests 71.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 79.94% <0.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit ea66755 into ros-controls:iron Mar 21, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Mar 21, 2024
(cherry picked from commit ea66755)

# Conflicts:
#	joint_trajectory_controller/src/joint_trajectory_controller.cpp
#	joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants