Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter check for geometric values (backport #1120) #1125

Merged
merged 2 commits into from
May 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Inspired by this post at RSE, I thought it could be a good idea to add simple checks to geometric values of the controllers for mobile robots. For example, wheel_radius wheel_base and others must not be zero ➡️ I added a gt<>: [0.0] validator for them. This also should help if a user misspelled or forgot these parameters.


This is an automatic backport of pull request #1120 done by Mergify.

@mergify mergify bot added the conflicts label May 9, 2024
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of 7170328 has failed:

On branch mergify/bp/humble/pr-1120
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 7170328.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ackermann_steering_controller/src/ackermann_steering_controller.yaml
	modified:   bicycle_steering_controller/src/bicycle_steering_controller.yaml
	modified:   diff_drive_controller/src/diff_drive_controller_parameter.yaml
	modified:   tricycle_steering_controller/src/tricycle_steering_controller.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   diff_drive_controller/test/test_diff_drive_controller.cpp
	deleted by us:   tricycle_controller/src/tricycle_controller_parameter.yaml
	both modified:   tricycle_controller/test/test_tricycle_controller.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich christophfroehlich marked this pull request as draft May 9, 2024 11:15
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (fe07b83) to head (04e961f).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1125      +/-   ##
==========================================
- Coverage   86.91%   86.67%   -0.24%     
==========================================
  Files          86       86              
  Lines        7595     7483     -112     
  Branches      620      620              
==========================================
- Hits         6601     6486     -115     
- Misses        761      762       +1     
- Partials      233      235       +2     
Flag Coverage Δ
unittests 86.67% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ive_controller/test/test_diff_drive_controller.cpp 93.06% <100.00%> (-2.83%) ⬇️
...ontroller/test/test_load_diff_drive_controller.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@christophfroehlich
Copy link
Contributor

@bmagyar bmagyar merged commit 2dabd0c into humble May 22, 2024
12 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1120 branch May 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ackermann_steering_controller with gazebo classic
2 participants