Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steering_controllers: Fix deprecation warning #1155

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

christophfroehlich
Copy link
Contributor

I made a mistake with #1093: The deprecation warning was inserted in the wrong place.
Will be removed with #1151 on rolling, but let's fix this on iron.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.79%. Comparing base (ced16a8) to head (1326505).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1155      +/-   ##
==========================================
+ Coverage   86.69%   86.79%   +0.09%     
==========================================
  Files          86       86              
  Lines        7411     7413       +2     
  Branches      612      613       +1     
==========================================
+ Hits         6425     6434       +9     
+ Misses        758      750       -8     
- Partials      228      229       +1     
Flag Coverage Δ
unittests 86.79% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...llers_library/src/steering_controllers_library.cpp 74.16% <0.00%> (-0.32%) ⬇️

... and 3 files with indirect coverage changes

@bmagyar bmagyar merged commit 94149be into iron Jun 3, 2024
12 checks passed
@bmagyar bmagyar deleted the steering_fix_deprecation branch June 3, 2024 11:29
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants