-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add PID controller 🎉 (backport #434, #975, #899, #1084, #951) #1162
Conversation
Needs ros-controls/control_msgs#133 to be released for the binary builds. |
(cherry picked from commit 038a547)
ff404a6
to
30f6030
Compare
* Add default yaml to docs * Add examples from test folder
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1162 +/- ##
==========================================
- Coverage 86.93% 86.76% -0.17%
==========================================
Files 87 92 +5
Lines 7966 8439 +473
Branches 630 708 +78
==========================================
+ Hits 6925 7322 +397
- Misses 799 854 +55
- Partials 242 263 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@christophfroehlich, That has been merged, right? Can the build check just be re-triggered? |
The binary build check fails until control_msgs has been released (there is a release, waiting for the next sync). I think this PR can be merged now, too @bmagyar ? |
Proposal for a new controller that provides PID functionality.
The controller can be used stand-alone, in a chain.
Measured states can be provided through the topic or state interface, depening on the concrete control arch.
For example, if you are having an external estimator, using topic might be eaiser at first then full integration into ros2_control.
The PR depends the following changes:
Looking forward for your feedback!
Testing dependencies:
This is an automatic backport of pull request #434 done by [Mergify](https://mergify.com).