Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add PID controller 🎉 (backport #434, #975, #899, #1084, #951) #1162

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 5, 2024

Proposal for a new controller that provides PID functionality.

The controller can be used stand-alone, in a chain.
Measured states can be provided through the topic or state interface, depening on the concrete control arch.
For example, if you are having an external estimator, using topic might be eaiser at first then full integration into ros2_control.

The PR depends the following changes:

Looking forward for your feedback!

Testing dependencies:

  control_msgs:
    type: git
    url: [email protected]:ros-controls/control_msgs.git
    version: add-generic-msgs-for-controller-references
  control_toolbox:
    type: git
    url: [email protected]:ros-controls/control_toolbox.git
    version: add-option-to-define-prefix-as-param-prefix
  ros2_controllers:
    type: git
    url: [email protected]:StoglRobotics-forks/ros2_controllers.git
    version: add-pid-controller

This is an automatic backport of pull request #434 done by [Mergify](https://mergify.com).

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Jun 5, 2024

Needs ros-controls/control_msgs#133 to be released for the binary builds.

@christophfroehlich christophfroehlich changed the title 🚀 Add PID controller 🎉 (backport #434) 🚀 Add PID controller 🎉 (backport #434, #975, #899, #1084, #951) Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 84.28875% with 74 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (143bfc9) to head (9d78d2c).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1162      +/-   ##
==========================================
- Coverage   86.93%   86.76%   -0.17%     
==========================================
  Files          87       92       +5     
  Lines        7966     8439     +473     
  Branches      630      708      +78     
==========================================
+ Hits         6925     7322     +397     
- Misses        799      854      +55     
- Partials      242      263      +21     
Flag Coverage Δ
unittests 86.76% <84.28%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pid_controller/test/test_load_pid_controller.cpp 100.00% <100.00%> (ø)
pid_controller/test/test_pid_controller.cpp 100.00% <100.00%> (ø)
..._controller/test/test_pid_controller_preceding.cpp 100.00% <100.00%> (ø)
pid_controller/test/test_pid_controller.hpp 83.14% <83.14%> (ø)
pid_controller/src/pid_controller.cpp 70.79% <70.79%> (ø)

... and 2 files with indirect coverage changes

@cooperrunyan
Copy link

cooperrunyan commented Jun 20, 2024

Needs ros-controls/control_msgs#133 to be released for the binary builds.

@christophfroehlich, That has been merged, right? Can the build check just be re-triggered?

@christophfroehlich
Copy link
Contributor

Needs ros-controls/control_msgs#133 to be released for the binary builds.

@christophfroehlich, That has been merged, right? Can the build check just be re-triggered?

The binary build check fails until control_msgs has been released (there is a release, waiting for the next sync). I think this PR can be merged now, too @bmagyar ?

@bmagyar bmagyar merged commit d693a87 into humble Jul 16, 2024
12 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-434 branch July 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants