Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STEERING] Add missing tan call for ackermann (backport #1117) #1176

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2024

The steering library is missing a call to calculate tangent from steering pos at ackermann code.


This is an automatic backport of pull request #1117 done by Mergify.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (b9cc260) to head (e3dc53e).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1176      +/-   ##
==========================================
+ Coverage   86.62%   86.98%   +0.35%     
==========================================
  Files          86       86              
  Lines        7492     7490       -2     
  Branches      619      617       -2     
==========================================
+ Hits         6490     6515      +25     
+ Misses        767      743      -24     
+ Partials      235      232       -3     
Flag Coverage Δ
unittests 86.98% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 73.79% <100.00%> (ø)

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 8c99191 into humble Jun 19, 2024
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1117 branch June 19, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants