Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the subscription timeout in the tests to 5ms #1219

Merged

Conversation

saikishor
Copy link
Member

Intends to fix #1218

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (96a8d57) to head (ba6fcf7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   86.57%   86.58%           
=======================================
  Files          95       95           
  Lines        8587     8585    -2     
  Branches      720      718    -2     
=======================================
- Hits         7434     7433    -1     
  Misses        883      883           
+ Partials      270      269    -1     
Flag Coverage Δ
unittests 86.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 86.59% <100.00%> (ø)
...nce_controller/test/test_admittance_controller.hpp 94.79% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <100.00%> (ø)
...ster/test/test_force_torque_sensor_broadcaster.cpp 97.24% <100.00%> (-0.92%) ⬇️
...r_broadcaster/test/test_imu_sensor_broadcaster.cpp 95.71% <100.00%> (ø)
..._broadcaster/test/test_joint_state_broadcaster.cpp 93.85% <100.00%> (ø)
pid_controller/test/test_pid_controller.hpp 84.61% <100.00%> (ø)
...broadcaster/test/test_range_sensor_broadcaster.cpp 94.73% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 96.87% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 85.05% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a try ;)

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after rerunning too, let's see how it does longer term!

@bmagyar bmagyar merged commit f7b1af1 into ros-controls:master Jul 18, 2024
17 of 20 checks passed
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message subscription in tests is flaky
3 participants