Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] [diff_drive_controller] Remove duplicated call to rclcpp::shutdown #1220

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Noel215
Copy link
Contributor

@Noel215 Noel215 commented Jul 18, 2024

No description provided.

@Noel215 Noel215 changed the title Remove duplicated call to rclcpp::shutdown [test] [diff_drive_controller] Remove duplicated call to rclcpp::shutdown Jul 18, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (f7b1af1) to head (58b0f2f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   86.57%   86.54%   -0.03%     
==========================================
  Files          95       95              
  Lines        8586     8587       +1     
  Branches      719      721       +2     
==========================================
- Hits         7433     7432       -1     
  Misses        883      883              
- Partials      270      272       +2     
Flag Coverage Δ
unittests 86.54% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@bmagyar bmagyar merged commit 990bfb6 into ros-controls:master Jul 18, 2024
16 of 20 checks passed
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants