Fix bug for displaying all controllers #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Martín Rico <[email protected]>
github-actions
bot
requested review from
aprotyas,
arne48,
bmagyar,
DasRoteSkelett,
destogl,
erickisos and
mcbed
|
@fmrico can you apply the pre-commit formatting changes |
Signed-off-by: Francisco Martín Rico <[email protected]>
|
Hi @saikishor !! Changes applied. Let's wait for CI |
|
and let's see the CI after Christoph's updates ;) |
This was referenced Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 105 105
Lines 9357 9356 -1
Branches 821 819 -2
=======================================
Hits 7523 7523
- Misses 1557 1558 +1
+ Partials 277 275 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
backport-iron
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
bmagyar
pushed a commit
that referenced
this pull request
Aug 29, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 29, 2024
RobertWilbrandt
pushed a commit
to RobertWilbrandt/ros2_controllers
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using the rqt_joint_trajectory_controller, not all the controllers are shown on the controller button. This is because the list of limits was not accumulated, and only the last one was considered. This PR fixes this, showing all the valid controllers.
I hope it helps
Francisco