Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writing_new_controller docs fix #790

Merged
merged 3 commits into from
Oct 6, 2023
Merged

writing_new_controller docs fix #790

merged 3 commits into from
Oct 6, 2023

Conversation

ARK3r
Copy link
Contributor

@ARK3r ARK3r commented Oct 6, 2023 •
edited
Loading

  • added some whitespace to fix code blocks
  • changed references to init function to on_init

@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #790 (40592de) into master (26a130b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   30.88%   30.88%           
=======================================
  Files           7        7           
  Lines         832      832           
  Branches      505      505           
=======================================
  Hits          257      257           
  Misses        133      133           
  Partials      442      442
Flag Coverage Δ
unittests 30.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ARK3r ARK3r changed the title fix docs broken structure writing_new_controller docs fix Oct 6, 2023
bmagyar
bmagyar approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Oct 6, 2023
@bmagyar bmagyar merged commit f62fc3a into ros-controls:master Oct 6, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Oct 6, 2023
@ARK3r @mergify
writing_new_controller docs fix (#790)
54a6d2c 
* fixing structure

* format

* typo fix

(cherry picked from commit f62fc3a)
@mergify mergify bot mentioned this pull request Oct 6, 2023
Merged
bmagyar pushed a commit that referenced this pull request Oct 7, 2023
@mergify
writing_new_controller docs fix (#790) (#791)
7dfdcaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@jackcenter jackcenter Awaiting requested review from jackcenter

@mhubii mhubii Awaiting requested review from mhubii

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ARK3r @bmagyar @aprotyas