-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
joint_state_broadcaster: Add proper subscription to TestCustomInterfaceMappingUpdate #859
Merged
bmagyar
merged 2 commits into
ros-controls:master
from
christophfroehlich:jsb/update_tests
Nov 27, 2023
Merged
joint_state_broadcaster: Add proper subscription to TestCustomInterfaceMappingUpdate #859
bmagyar
merged 2 commits into
ros-controls:master
from
christophfroehlich:jsb/update_tests
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Nov 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 44.88% 45.32% +0.44%
==========================================
Files 40 40
Lines 3636 3636
Branches 1716 1716
==========================================
+ Hits 1632 1648 +16
+ Misses 832 817 -15
+ Partials 1172 1171 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmagyar
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned with #821, one tests of joint_state_broadcaster is flaky in the coverage build job. This is because the creation of the
joint_state_msg
is not ensured due to a failingtrylock()
when callingupdate()
only onceros2_controllers/joint_state_broadcaster/src/joint_state_broadcaster.cpp
Line 353 in 0d3fc52
I reused the wait set from other tests, which retries the update several times.
Unfortunately, I was not able to reproduce a failing test like in the CI, but this should fix #821 (other tests using the wait_set are not flaky).