Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point comparison in JTC (backport #879) #880

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 4, 2023

This is an automatic backport of pull request #879 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix floating point comparison in JTC

* Fix format

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit 71b06d0)
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #880 (4a17a4f) into iron (29fae61) will increase coverage by 0.41%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron     #880      +/-   ##
==========================================
+ Coverage   46.62%   47.03%   +0.41%     
==========================================
  Files          40       40              
  Lines        3655     3655              
  Branches     1728     1728              
==========================================
+ Hits         1704     1719      +15     
+ Misses        762      747      -15     
  Partials     1189     1189              
Flag Coverage Δ
unittests 47.03% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 48.75% <0.00%> (ø)

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit fb7397e into iron Dec 5, 2023
13 of 15 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-879 branch December 5, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants