Depend on system install of libfreenect rather than ROS repositories #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork targets ROS
melodic
and addresses how dependent files are referenced.In previous releases of
freenect_stack
(like those forLunar
andKinetic
) it has depended implicitly on the version oflibfreenect
released by ros-drivers.libfreenect
andlibfreenect-dev
are also distributed in the Linux ecosystems. However, the wayfreenect_stack
looks for header files prevents installations oflibfreenect
byapt
and other installers, from being found. These installations place header files in/usr/include/
rather than/usr/include/libfreenect/
, which is wherefreenect_camera
assumes them to live.This fork changes the dependency on the
ros-drivers/libfreenect
to the more broadly distributedlibfreenect
, which has an existing rosdep key oflibfreenect-dev
, and changes code to look for installed headers in place that theapt
libfreenect
installs them.Considering the
ros-drivers
version oflibfreenect
is no longer maintained, and behind the latest release of the aptlibfreenect
, moving away from theros-drivers
version seems reasonable to me.