-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/irb6660 #113
base: kinetic-devel
Are you sure you want to change the base?
Feature/irb6660 #113
Conversation
Update link list and joint list parameter to matched ABB IRB6660_100_330 data
Upload all 3 vairiances moveit config
…_experimental.git into feature/irb6660
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my view this PR still needs some changes.
@@ -1,4 +0,0 @@ | |||
cmake_minimum_required(VERSION 2.8.3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two abb_experimenal/
files should not be deleted.
<!-- | ||
Manipulator specific version of the state visualizer. | ||
|
||
Defaults provided for irb_6650s_90: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong robot model here and in the usage line
@@ -0,0 +1,11 @@ | |||
moveit_setup_assistant_config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As moveit configs are usually application dependant they should probably not be part of this pull request.
Adding irb6660 (and variants) support and moveit config