Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/irb6660 #113

Open
wants to merge 8 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

wlg1984
Copy link

@wlg1984 wlg1984 commented Mar 22, 2019

Adding irb6660 (and variants) support and moveit config

Copy link

@kinneyjustin kinneyjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

kinneyjustin
kinneyjustin previously approved these changes May 8, 2019
Copy link
Contributor

@cjue cjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my view this PR still needs some changes.

@@ -1,4 +0,0 @@
cmake_minimum_required(VERSION 2.8.3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two abb_experimenal/ files should not be deleted.

<!--
Manipulator specific version of the state visualizer.

Defaults provided for irb_6650s_90:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong robot model here and in the usage line

@@ -0,0 +1,11 @@
moveit_setup_assistant_config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As moveit configs are usually application dependant they should probably not be part of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants