Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for retrieving present options and modules #46

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Added support for retrieving present options and modules #46

merged 4 commits into from
Jun 14, 2019

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Mar 7, 2019

As per title.

Related to issue #45.

gavanderhoorn
gavanderhoorn previously approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as it seems OK as-is, but I would recommend accepting some of my suggestions.

include/abb_librws/rws_client.h Show resolved Hide resolved
include/abb_librws/rws_client.h Show resolved Hide resolved
include/abb_librws/rws_client.h Show resolved Hide resolved
include/abb_librws/rws_common.h Show resolved Hide resolved
include/abb_librws/rws_common.h Outdated Show resolved Hide resolved
include/abb_librws/rws_interface.h Show resolved Hide resolved
include/abb_librws/rws_interface.h Outdated Show resolved Hide resolved
include/abb_librws/rws_interface.h Show resolved Hide resolved
src/rws_client.cpp Show resolved Hide resolved
src/rws_interface.cpp Show resolved Hide resolved
@jontje jontje dismissed stale reviews from gavanderhoorn via 98111b5 March 11, 2019 14:12
@jontje jontje mentioned this pull request Mar 11, 2019
Open
gavanderhoorn
gavanderhoorn approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

@gavanderhoorn
Copy link
Member

@jontje: feel free to merge. I somehow not got notified of the fact that you had pushed a new commit.

@jontje
Copy link
Contributor Author

jontje commented Jun 14, 2019

No worries @gavanderhoorn, thanks for the review 👍

@jontje jontje merged commit 8e41199 into ros-industrial:master Jun 14, 2019
@jontje jontje deleted the get_present_options_and_modules branch June 14, 2019 09:00
@gavanderhoorn gavanderhoorn mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jontje @gavanderhoorn