[indigo][industrial_extrinsic_cal] Add missing dependency #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinDeric
reviewed
Sep 21, 2017
.travis.yml
Outdated
| PRERELEASE=true | ||
| matrix: | ||
| allow_failures: | ||
| - env: ROS_DISTRO="indigo" PRERELEASE=true |
There was a problem hiding this comment.
Interesting, why add these lines?
There was a problem hiding this comment.
In this line I'm adding ROS pre-release test feature. It should fail at least for now since this package isn't release ready so that it shouldn't be taken into account for merge decision, but is useful when release becomes an option.
if release will never be an option this can be omitted, but IMO having it wouldn't hurt except it tends to take a little longer than "normal" jobs so that you may need to wait longer to see the CI result.
130s
force-pushed
the
i/fix/dependency_wo_ceres
branch
from
f09a4cc to
01cd82d
Compare
130s
force-pushed
the
i/fix/dependency_wo_ceres
branch
from
01cd82d to
94b87bf
Compare
130s
force-pushed
the
i/fix/dependency_wo_ceres
branch
from
94b87bf to
536014b
Compare
|
Closing in favor of #109 that is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #109, this PR does not depend on the binary version of ceres.