Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory action should abort on robot error. #83

Closed
wants to merge 1 commit into from

Conversation

hersh
Copy link

@hersh hersh commented Aug 25, 2014

When a robot status message is received with a non-zero error code, any active trajectory goal should be aborted. Without this, the only way to know that a failure has happened is for the action client to time-out.

Also fixed some compiler warnings about printing unsigned integers with %d format.

@shaun-edwards
Copy link
Member

@hersh, thanks for this contribution. I'm going to try it out on our hardware before I accept the PR. Should be a couple of days.

@gavanderhoorn
Copy link
Member

I like this, but should the abort of the goal (and sending of the FollowJointTrajectoryResult) perhaps be done somewhere else instead of directly here in the RobotStatus callback? Maybe in controllerStateCB(..)?

@gavanderhoorn
Copy link
Member

Also: perhaps we should actually check the in_error field, instead of error_code (or both)? I can imagine not all errors (on the industrial controller) immediately lead to an inability to complete the goal?

@gavanderhoorn
Copy link
Member

Rebase + improvements in #271.

really late, but I'd still like to thank @hersh for making the effort to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants