Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add Axis-Aligned Bounding Box option to Plane-Slicer Planner #123

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

WIP: Add Axis-Aligned Bounding Box option to Plane-Slicer Planner #123

wants to merge 76 commits into from

Commits on Dec 17, 2020

  1. Add Axis-Aligned Bounding Box option to Plane-Slicer Planner

    @DavidMerzJr
    DavidMerzJr authored and Colin Lewis committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    812f52e View commit details
    Browse the repository at this point in the history

  2. Clang fixes and PlaneSlicerConfig Serialization

    @DavidMerzJr
    DavidMerzJr committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4e32857 View commit details
    Browse the repository at this point in the history

  3. implemented simple max_edge_segment function

    @steviedale
    steviedale committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4e5c022 View commit details
    Browse the repository at this point in the history

  4. added max_segment_length msg params

    @steviedale
    steviedale committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a52ac5a View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. fixed lenth->length typo and made splitSegments turn off for max_segm… 

    …ents_legnths <= 0
    @steviedale
    steviedale committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    12181b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. added generate_extra_rasters capability to the plane slicer raster pl… 

    …anner
    @drchrislewis
    drchrislewis committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    40551b3 View commit details
    Browse the repository at this point in the history

  2. clang format

    @drchrislewis
    drchrislewis committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    54dffd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Merge pull request #2 from drchrislewis/generate_extra_rasters 

    Generate extra rasters
    @DavidMerzJr
    DavidMerzJr committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    7dd640d View commit details
    Browse the repository at this point in the history

  2. inprogress, but rebasing

    @drchrislewis
    drchrislewis committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    0a88246 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. first compile of bug fix for raster across holes switching directions… 

    … of plane slicer
    @drchrislewis
    drchrislewis committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8693919 View commit details
    Browse the repository at this point in the history

  2. Fix plane slicer axes for vertical parts and offsets for first slice

    David Merz, Jr authored and Colin Lewis committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    08c6a00 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. reordered, but now all returned rasters flow in same order. TODO, add… 

    … flag to set reverse raster style
    @drchrislewis
    drchrislewis committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    3ac6cf9 View commit details
    Browse the repository at this point in the history

  2. added function to reverse odd rasters, and a config to enable/disable… 

    … flip orientation on odd rasters
    @drchrislewis
    drchrislewis committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    308194e View commit details
    Browse the repository at this point in the history

  3. clang

    @drchrislewis
    drchrislewis committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f804f23 View commit details
    Browse the repository at this point in the history

  4. removed some code between if(0)

    @drchrislewis
    drchrislewis committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    4ffd272 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. minor changes to catch zero length cases

    @drchrislewis
    drchrislewis committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    14746af View commit details
    Browse the repository at this point in the history

  2. minor improvement

    @drchrislewis
    drchrislewis committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    acf9da4 View commit details
    Browse the repository at this point in the history

  3. clang

    @drchrislewis
    drchrislewis committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    37ccd05 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from drchrislewis/reorder_planeslice_segs 

    Reorder planeslice segs
    @DavidMerzJr
    DavidMerzJr committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    80d33a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Update cmake_common_scripts to ros_industrial_cmake_boilerplate

    Levi Armstrong committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    7b03eae View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Merge pull request #4 from Levi-Armstrong/feature/axis-aligned-boundi… 

    …ng-box

Update cmake_common_scripts to ros_industrial_cmake_boilerplate
    @DavidMerzJr
    DavidMerzJr committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5d0911f View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. fixed bug in utility to add extra raster

    Colin Lewis committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c698b1c View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. first compile no testing yet

    @drchrislewis
    drchrislewis committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    4999eae View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. implemented segmentByAxes

    @steviedale
    steviedale committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d76613e View commit details
    Browse the repository at this point in the history

  2. added testing script (should probably delete this before merging)

    @steviedale
    steviedale committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    9f8c123 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. addingExtraWaypoints is now working under gtest examples

    @drchrislewis
    drchrislewis committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    327acf9 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. updated segmentByAxes with major axis detection

    @steviedale
    steviedale committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    f58ccca View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. added gtest unit test for segmentByAxes, viz not working and needs mo… 

    …re test cases
    @steviedale
    steviedale committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2b1527f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. updated addWaypoints to prefer the original over the shifted. This pr… 

    …oduces smoother paths
    @drchrislewis
    drchrislewis committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    bf3547d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. modified prunning to use dot product as method.

    @drchrislewis
    drchrislewis committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6bee60f View commit details
    Browse the repository at this point in the history

  2. replaces splitSegements() with segmentByAxes() in edge generators

    @steviedale
    steviedale committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4ccb86a View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. modified conditions for adding extra waypoints. This should eliminate… 

    … errant extra waypoints added due to high curvature issues.
    @drchrislewis
    drchrislewis committed May 4, 2021
    Configuration menu
    Copy the full SHA
    725267d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. fixed a few bugs in addExtraWaypoints, added a test that loads a mesh… 

    … from /tmp if it exists to facilitate better testing
    @drchrislewis
    drchrislewis committed May 5, 2021
    Configuration menu
    Copy the full SHA
    d423984 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. edge path points are condsidered in a centroid frame to improve behavior

    Colin Lewis committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d8ab78e View commit details
    Browse the repository at this point in the history

  2. removed debug data structure

    Colin Lewis committed May 6, 2021
    Configuration menu
    Copy the full SHA
    e3bc666 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from colin-lewis-19/feature/segment_by_axes 

    Feature/segment by axes
    @steviedale
    steviedale committed May 6, 2021
    Configuration menu
    Copy the full SHA
    694c15a View commit details
    Browse the repository at this point in the history

  4. refactored segementByAxes to splitByAxes

    @steviedale
    steviedale committed May 6, 2021
    Configuration menu
    Copy the full SHA
    510511a View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Merge pull request #5 from drchrislewis/addExtraWaypoints 

    Add extra waypoints
    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    2b26ffa View commit details
    Browse the repository at this point in the history

  2. Reset Value in Utest

    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    793fdb4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/axis-aligned-bounding-box' into feature/segment… 

    …_by_axes
    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    2320237 View commit details
    Browse the repository at this point in the history

  4. Fix specification of raster direction to be more consistent

    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    2861348 View commit details
    Browse the repository at this point in the history

  5. Fix repeated uses causing changes in behavior

    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    f28beac View commit details
    Browse the repository at this point in the history

  6. Fix Vector Math

    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a3bea86 View commit details
    Browse the repository at this point in the history

  7. Fix Strange Deflection when Specifying Raster Direction Directly 

    Specified raster directions in the plane slicer were modified in a seemingly random way.

It turns out that I was transforming the raster direction (A 3d vector) with the full transform from mesh frame to bounding box frame.  However, it was being treated as a point, not a vector - i.e., the translation was being applied.

I have enacted a change to ensure that only the rotation component is now being applied, and added a test case to the unit test to verify sensible behavior.
    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    734f27c View commit details
    Browse the repository at this point in the history

  8. Appease Clang and Fixup Unit Test

    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    f805353 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #7 from DavidMerzJr/fix/raster-direction-specifica… 

    …tion

Fix specification of raster direction to be more consistent
    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9ef7316 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/axis-aligned-bounding-box' into feature/segment… 

    …_by_axes
    @DavidMerzJr
    DavidMerzJr committed May 12, 2021
    Configuration menu
    Copy the full SHA
    7b64064 View commit details
    Browse the repository at this point in the history

  11. removed test node

    @steviedale
    steviedale committed May 12, 2021
    Configuration menu
    Copy the full SHA
    d845ba5 View commit details
    Browse the repository at this point in the history

  12. fixed fail cases

    @steviedale
    steviedale committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e9671a0 View commit details
    Browse the repository at this point in the history

  13. removed unused dependency from CMakeLists.txt

    @steviedale
    steviedale committed May 12, 2021
    Configuration menu
    Copy the full SHA
    3688fa4 View commit details
    Browse the repository at this point in the history

  14. support for splitting ToolPath objects with multiple ToolPathSegment … 

    …objects
    @steviedale
    steviedale committed May 12, 2021
    Configuration menu
    Copy the full SHA
    78b6fc2 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Merge pull request #6 from steviedale/feature/segment_by_axes 

    Edge Path Splitting by Axes
    @DavidMerzJr
    DavidMerzJr committed May 20, 2021
    Configuration menu
    Copy the full SHA
    01bec84 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Trying to Correct Malformed Post-Filtering Meshes

    @DavidMerzJr
    DavidMerzJr committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ef6fa61 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. reinstated a heat_raster interface and made a few minor simplifying c… 

    …hanges and comments
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    49837e1 View commit details
    Browse the repository at this point in the history

  2. clang tidy

    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    8cc8584 View commit details
    Browse the repository at this point in the history

  3. added call to smoother and a utility function to generate interleaved… 

    … paths for sanding
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    b79f539 View commit details
    Browse the repository at this point in the history

  4. added search_radius to service so that we average the normals over so… 

    …me distance rather than using just one
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    6419c78 View commit details
    Browse the repository at this point in the history

  5. fixed quite a few bugs in the plane slicer. These caused crashes. Thi… 

    …s is still a WIP.
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    ef05d02 View commit details
    Browse the repository at this point in the history

  6. added parameters to service call to plane slicer for smoothing, and i… 

    …nterleaving rasters
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    b53758d View commit details
    Browse the repository at this point in the history

  7. updated utilities to allow normal estimation using MLS

    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    8ea64ab View commit details
    Browse the repository at this point in the history

  8. updated method for setting x-direction of pose

    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    07e3f7f View commit details
    Browse the repository at this point in the history

  9. added MLS normal estimation and other utility functions(e.g. compute … 

    …face and vertex normals from mesh either as shape_msg or pcl::Polygonmesh. Modified plane slicer to use MLS for its normal estimation.
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    caad679 View commit details
    Browse the repository at this point in the history

  10. removed include file no longer necessary

    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d6a59f1 View commit details
    Browse the repository at this point in the history

  11. clang, removed unnecessary and complex if(), renamed a static functio… 

    …n in half-edge code.
    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    189eef2 View commit details
    Browse the repository at this point in the history

  12. text of error message corrected

    @drchrislewis @marrts
    drchrislewis authored and marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    224d6fb View commit details
    Browse the repository at this point in the history

  13. Fixed extra raster_directions param that slipped through on rebase

    @marrts
    marrts committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    4f0a139 View commit details
    Browse the repository at this point in the history

  14. Merge pull request #12 from marrts/smoothing_and_interleaving_rebase 

    Smoothing and interleaving rebased
    @DavidMerzJr
    DavidMerzJr committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    fdbf72e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Fixed default raster direction to be zero vector rather than unit Y s… 

    …o that it defaults to longest side of bounding box
    @marrts
    marrts committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    74246a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Merge pull request #13 from marrts/fix/raster_direction_default 

    Fixed default raster direction
    @DavidMerzJr
    DavidMerzJr committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e41a18e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Reorganizing and Missing Headers

    @DavidMerzJr
    DavidMerzJr committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5899b4d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Sequencer: Guard against disallowed front() back()

    @DavidMerzJr
    DavidMerzJr authored and RARS Desktop committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    41a65ae View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Added ability to hop inlets and peninsulas

    @marrts
    marrts committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e751fc6 View commit details
    Browse the repository at this point in the history

  2. Clang formatting and renamed variables to be clearer

    @marrts
    marrts committed May 10, 2022
    Configuration menu
    Copy the full SHA
    958d584 View commit details
    Browse the repository at this point in the history

  3. Clarified param units and better infinite loop check

    @marrts
    marrts committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f033397 View commit details
    Browse the repository at this point in the history

  4. Ensures monotonically decreasing toolpath sizes

    @marrts
    marrts committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6713141 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #14 from marrts/feature/peninsula_and_inlet_hopper 

    Added ability to hop inlets and peninsulas
    @DavidMerzJr
    DavidMerzJr committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0135230 View commit details
    Browse the repository at this point in the history