-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raster utils #262
base: dev
Are you sure you want to change the base?
Raster utils #262
Conversation
c89cdbc
to
31663f7
Compare
Do you think all of these are worth pulling out as utility functions? My impression was that most of these were really just supporting the plane slice raster planner and might not be useful on their own. I don't mind moving them to the plane slice raster header to make them includable, but I wonder if they're worth exposing as general purpose utilities |
That was my starting place, but looking back now I don't think that it's really necessary to have all of them pulled out. Maybe a mix of putting some in the plane slice header and a new raster_utils file? For creating the new drawn toolpath plugin for snp I needed to use:
These are both moreso mesh utilities that a toolpath planner might want. Most of the other things feel more like plane slicer, or a raster pattern specific task that could be moved back to the original file, but with a header declaration to be includable |
Okay, I think that sounds like a good plan. Can you update the description/variable names of |
d1fce84
to
8d58e52
Compare
I can separate this into 2 PRs if needed, but this does two things.