Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake error on first build #99

Closed
wants to merge 1 commit into from

Conversation

dave992
Copy link

@dave992 dave992 commented Aug 3, 2020

When building the noether package for the first time (or after cleaning the workspace) it fails with the following errors as mentioned in #98 (comment):

Errors     << noether_filtering:cmake /catkin_ws/logs/noether_filtering/build.cmake.000.log                                                                                              
CMake Error:
  Error evaluating generator expression:

    $<COMPILE_LANGUAGE:CXX>

  $<COMPILE_LANGUAGE:...> may only be used to specify include directories,
  compile definitions, compile options, and to evaluate components of the
  file(GENERATE) command.

...

PCL NURBS FOUND
Building mesh plugins
cd /catkin_ws/build/noether_filtering; catkin build --get-env noether_filtering | catkin env -si  /usr/bin/cmake /catkin_ws/src/noether/noether_filtering --no-warn-unused-cli -DCMAKE_INSTALL_PREFIX=/catkin_ws/devel; cd -

Running catkin build again then allows noether to build successfully. In #98 (comment) it is advised to try the fix implemented in this PR, which solves the first build issue.

Copy link
Member

@Levi-Armstrong Levi-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the issue on how to better address this issue.

@dave992
Copy link
Author

dave992 commented Aug 10, 2020

Fair enough, I just assumed here that this check may be redundant as the instructions on how to install PCL are quite clear and prominently shown in the readme.

I do not know what actually happens when NURBS is not built correctly, so this may be a bad solution indeed in case the resulting errors are not easily interpretable.

I'll close this then.

@dave992 dave992 closed this Aug 10, 2020
@dave992 dave992 deleted the first_build_fix branch August 10, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants