You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The *_gazebo.launch files currently expose a remap argument that, when true, remap the default topics from the gazebo_ros plugin (and friends) to the ROS-Industrial driver spec compliant ones.
remap is too generic a name, and should be changed into something which more clearly conveys its purpose / effect.
The text was updated successfully, but these errors were encountered:
Good idea. Besides renaming "remap" to something more meaningful, I think using the ROS-Industrial driver spec compliant topics by default would be a good idea. Since this is a ROS-Industrial repo, it makes a lot of sense to work with the industrial convention in gazebo by default.
What about extending the argument "remap" to something more meaningful like "ros_remapping", "ros_remap", "ros_i_remapping" or "ros_i_remap" and set the default value to true.
The
*_gazebo.launch
files currently expose aremap
argument that, whentrue
, remap the default topics from thegazebo_ros
plugin (and friends) to the ROS-Industrial driver spec compliant ones.remap
is too generic a name, and should be changed into something which more clearly conveys its purpose / effect.The text was updated successfully, but these errors were encountered: