Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo: give 'remap' launch arg a more descriptive name #7

Open
gavanderhoorn opened this issue Apr 1, 2016 · 4 comments
Open

gazebo: give 'remap' launch arg a more descriptive name #7

gavanderhoorn opened this issue Apr 1, 2016 · 4 comments

Comments

@gavanderhoorn
Copy link
Member

The *_gazebo.launch files currently expose a remap argument that, when true, remap the default topics from the gazebo_ros plugin (and friends) to the ROS-Industrial driver spec compliant ones.

remap is too generic a name, and should be changed into something which more clearly conveys its purpose / effect.

@gavanderhoorn
Copy link
Member Author

Launch files in rx160_gazebo and the to-be-introduced tx90_gazebo packages (see #6) are affected.

@nilsmelchert
Copy link
Contributor

Good idea. Besides renaming "remap" to something more meaningful, I think using the ROS-Industrial driver spec compliant topics by default would be a good idea. Since this is a ROS-Industrial repo, it makes a lot of sense to work with the industrial convention in gazebo by default.

@nilsmelchert
Copy link
Contributor

What about extending the argument "remap" to something more meaningful like "ros_remapping", "ros_remap", "ros_i_remapping" or "ros_i_remap" and set the default value to true.

@nilsmelchert
Copy link
Contributor

So if I did a PR for this, would you consider merging it? Or is there a reason not to do these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants