-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Gazebo support for Staubli TX90 family #6
Introducing Gazebo support for Staubli TX90 family #6
Conversation
@gavanderhoorn I split the old PR into two PRs. I got things a bit muddled up, but I think it looks tidy now... |
<!-- Gazebo-specific link properties --> | ||
<gazebo reference="${prefix}base_link"> | ||
<material>Gazebo/Yellow</material> | ||
<turnGravityOff>true</turnGravityOff> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have discussed this before, but why is turnGravityOff
set to true
here?
I cannot remember exactly (it is disabled in the xacro files for the RX160 models). I vaguely remember something related to testing, perhaps before I had the masses, coms, and inertia matrices from SolidWorks. |
@gavanderhoorn leave it consistent with RX160 models for now? |
Yes, that would make sense for now. |
<launch> | ||
<arg name="paused" default="false"/> | ||
<arg name="gui" default="true"/> | ||
<arg name="remap" default="false"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: should we perhaps rename this argument to something like rosi_compat
or rosind_compat
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Shall we do that for the RX160 family too?
I'll address this soon-ish.
@MuriloMartins: did you still want to make some changes to this PR? If not, I can merge it in manually, as I've done with #5. |
Hi @gavanderhoorn ! |
@MuriloMartins wrote:
yes, that makes sense. See #7. I'll put this PR on my merge-TODO list then. |
@MuriloMartins: just merged this manually (to resolve the conflicts after I merged #5). See 5d12ff4. Thanks again for contributing, much appreciated :). |
Adding Gazebo-related files to simulate the Staubli TX90 family.
Please note that this PR depends on PR #5 .