Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow velocity override #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonschmeisser
Copy link

the velocity override was commented out without further description in 4cbb7f9 by @marshallpowell97

as our customer is not seeing attractive velocities (similar to #30 I assume but I did not yet capture details) we wanted to use the velocity override mode by changing this line

@gavanderhoorn
Copy link
Member

This was commented I believe as a result of the discussion in #1.

@simonschmeisser
Copy link
Author

Thanks for reminding me of that discussion, then it would be more sensible to put a 100 there I assume. (It's off by default anyway so it shouldn't be a safety concern).
Or to scale/override the values on the PC. Or to investigate #30 some more

@carpintas
Copy link

On #1 they have a good point, if you set the motion descriptor velocity equal to the current monitor speed, at a speed below 100% you will get the reduction 2 times, this is if it is 50% you set the robot to be 50% of 50%, which is 25%. Unless the speed value comes as a "ROS parameter or something similar", l_mTrajPt.mDesc.vel = getMonitorSpeed() must be commeted.

Copy link

@carpintas carpintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the motion descriptor velocity to the speed monitor doesn't make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants