Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prefix argument to ur.xacro #659

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

Doomerdinger
Copy link

There are some use cases where being able to specify the prefix in the non-macro xacro file is useful.

Adding this should have no impact on any existing use cases.

I can add this argument to the other "concrete" xacro files, but I believe in nearly all cases where this is relevant the user will favor using the generic file anyway.

As a side note, this argument is provided in the non-macro file of the ROS2 description repo.

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Oct 10, 2023

There are some use cases where being able to specify the prefix in the non-macro xacro file is useful.

Could you give an example where this would be useful?

As you already write yourself, this .xacro file is supposed to be a top-level one and is not meant for composition. I'm having a hard time coming up with a use-case for a prefix.

@Doomerdinger
Copy link
Author

Doomerdinger commented Oct 10, 2023

An example would be when using external tooling to compose URDFs, but still wanting to utilize existing xacro files alongside/within those tools.
By virtue of what those tools are attempting, they essentially must be able to parse URDF properly, but may not support parsing/resolving xacro macros.
In such cases, it can be useful to have a top-level xacro file that essentially wraps the macro more or less 1:1, so that xacro itself can be called on that top-level file and the resulting valid URDF file fed into the other tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants